Skip to content

Conversation

@stuartmorgan-g
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g commented Oct 12, 2022

Updates .cirrus.yaml to better match flutter/plugins, as a step toward eventually merging the repsositories. Changes include:

  • Separating out light workload and heavy workload Linux tasks with different machine specs.
  • Enabling analyze on stable in addition to master, which was missing only as an oversight.
  • Skips platform tests on stable, as we now do in the plugins repo.
  • Separates format and other repo-level, channel-agnostic checks from analyze (mostly to support the above).
  • Combines some very cheap steps that don't need to be separate, to reduce machine/setup overhead.
  • Cleans up some desktop enabling steps that are no longer necessary.
  • Minor flag and comment adjustment to match across repos to aid with diffing.

Since analysis now runs on stable, one analysis option that's not on stable yet had to be commented out.

Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, but I don't know much about cirrus or it's configs, so I'd wait for @bparrishMines if you want a real review, up to you. :)

Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 19, 2022
@auto-submit auto-submit bot merged commit 4f34e50 into flutter:main Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants